btree iterator doesn't appear to work

[freekvw]

The increment operation on the iterator in tpie::btree does not always terminate.

[tyilo]

Is this still a problem?

If so, do you have a test case?

[freekvw]

I just checked, and currently we crash when the iterator appears to get to the end. Jakob is working on a testcase, but isn't done yet.

[antialize]

Running
tpie/build/apps/siv_dump/siv_dump /tmp/dataset.siv
faults while
tpie/build/apps/siv_dump/siv_dump --recursive /tmp/dataset.siv
succedes

example.zip

[tyilo]

I found the problem: For serialized btrees t.end() != t.end() (same with begin). I'm working on a fix.

[tyilo]

Should be fixed by 09a2e18

[antialize]

I don't think this fix works.

if i do

for (auto it=tree.begin(); it != tree.end(); ++it) {...}

It appears to fail as a new end node is constructed and deleted for every loop iteration. Also these lookups in unordered maps could be slow. Would it not be better to fix the comparison to use the offset?

[tyilo]

Works on my computer.

[antialize]

We should not use unordred maps to cache nodes. We should fix the comparision..

[tyilo]

Fair enough, should be fixed in 1b6534f

[ssoelvsten]

Is this still a problem?