Don't put "View changes since the review" into every single comment

[RalfJung]

Here, I submitted a bunch of comments at once. I didn't write a summary comment.

triagebot then for some reason decided to put a "View changes since the review" link into every one of my comments. I think that's excessive. I appreciate wanting to put the link somewhere, but then maybe put it in just in the first comment?

These links don't just take up space and distract from the comment contents, there's also a downside to editing the user's comment: if I edit my own comment just after submitting it, I get an error from GH. It seems GH detects that my edit would overwrite the bot's edit and then blocks my edit (but the error explains nothing so this is handled in a rather bad way by GH). I ran into this two times just in the past 5 days... not sure what could be done here. Both of these were just single comments that I submitted separately, not as part of a review. Maybe those shouldn't get a diff link?

[Urgau]

It's quite difficult for us to only post it once.

The best way to avoid it is to have a review body/description, that only put the link on the review and not on the review comments.

[RalfJung]

As a minor improvement, could you put that link at the end of the comment rather than the beginning? You do put it at the end for top-level review comments but at the beginning for line-attached review comments.

[Urgau]

Well we could but it was very such intentional to put it at the start the review comment.

My reasoning is that reviewers won't see the link at the end of a review comment, since I (and I suspect others) filters reviews comments based on the first few sentences and as such risk missing it. (This I feel is not the same with reviews)

This is however just a gut feeling on my part, I'm open to moving it.

@Kobzol any opinion? should we move to the end of the review comment?

[RalfJung]

Currently it is just inconsistent.

I (and I suspect others) filters reviews comments based on the first few sentences

Yes, exactly. Hence I want the first few words/sentences to be meaningful, not some boilerplate like this diff link. If I am looking for the diff link I know where to look as it's always at the end.

[Urgau]

Fair enough, opened #2374 to move it at the end.

[Kobzol]

I think this is one of those things where some people are bothered by option A and if we change it to B a different set of people will be bothered by B and they would like A 😆 But we can try it and see if anyone complains.

[Urgau]

Ideally we would put the link next to the "View reviewed changes" button on the review, but we don't have such control over the interface, so as you said, it's always going to be trade of.