Tracking Issue for `substr_range` and related methods

[wr7]

View all comments

Feature gate: #![feature(substr_range)]

This is a tracking issue for str::substr_range, slice::subslice_range, and slice::element_offset as described in this ACP.

These methods can be used for error handling and to extend str::lines, str::split, slice::split, and other related methods.

Public API

impl str {
    fn substr_range(&self, substr: &str) -> Option<range::Range<usize>>;
}

impl<T> [T] {
    fn subslice_range(&self, subslice: &[T]) -> Option<range::Range<usize>>;

    // Already stabilized as `element_offset`
    fn element_offset(&self, element: &T) -> Option<usize>;
}

Steps / History

• ACP
• Implementation: Add elem_offset and related methods #126770
• Rename elem_offset to element_offset #132830
• Final comment period 1 (FCP)¹
• Stabilization PR 1: Stabilize slice::element_offset #150777
• Change to use the new Range types Make substr_range and subslice_range return the new Range type #154707
• Final comment period 2 (FCP)¹
• Stabilization PR 2: Stabilize substr_range and subslice_range #141266

Unresolved Questions

• Switch to the new std::range return types

Footnotes

1. https://std-dev-guide.rust-lang.org/feature-lifecycle/stabilization.html ↩ ↩²

[tgross35]

Bikeshed: element_offset or item_offset seems better to me than abbreviating to elem, there aren't many truncated words in the slice method names. And e.g. std::simd uses rotate_elements_{left,right} and {Mask,Simd}Element (that is unstable API, but has been around for a while)

[wr7]

Bikeshed: element_offset or item_offset seems better to me than abbreviating to elem, there aren't many truncated words in the slice method names. And e.g. std::simd uses rotate_elements_{left,right} and {Mask,Simd}Element (that is unstable API, but has been around for a while)

+1
I'm somewhat impartial to the naming, but I think naming it element_offset might make sense. It's much more descriptive than "item", and the current documentation for slices appears to use the term "element" much more than "item".

I originally thought that "element" seems kinda long, but it's actually shorter than "subslice", so I think it's fine.

The elem_offset naming for the method was from a t-libs-api meeting, so I think I'll wait to see if I get more feedback from the rust community on the name before renaming it.

[ericlagergren]

Should they be const?

[wr7]

Should they be const?

Good question

I think that it would be great for them to be const, but a const implementation does not seem to be trivial in current-day rust.

I can see two main ways of implementing something similar to the proposed methods:

1. (Current implementation) Cast the pointers into usizes and then use wrapping_sub and wrapping_add on them. The issue with this is that you cannot cast pointers into usizes in const contexts. I don't see this changing too soon in the future either.
2. Using pointer::byte_offset_from. This is const, and this would work most of the time, but in cases where this method should return None, pointer::byte_offset_from would invoke undefined behavior, and there is no obvious way to get around this.

Fortunately, the most common use cases aren't currently const either. Methods like str::split return iterators which currently cannot be used in const contexts.

Making these methods const is a non-breaking change, so I personally think that we should move forwards with non-const implementations and file a separate issue in the future if constness is desired enough.

[jongiddy]

The documentation for subslice_range says:

Returns None if subslice does not point within the slice or if it points between elements.

My initial impression of the second part of this statement was that an empty slice that was within the slice would return None.

Looking at the code, the meaning appears to be that a slice that points to a byte inside a single element returns None. That is the opposite of pointing between elements. Can this be rewritten as:

Returns None if subslice does not point to the start of an element within the slice or to the end of the slice.

The same comment applies to elem_offset but it is more restricted:

Returns None if element does not point to the start of an element within the slice.

[wr7]

The documentation for subslice_range says:

Returns None if subslice does not point within the slice or if it points between elements.

My initial impression of the second part of this statement was that an empty slice that was within the slice would return None.

Looking at the code, the meaning appears to be that a slice that points to a byte inside a single element returns None. That is the opposite of pointing between elements. Can this be rewritten as:

Returns None if subslice does not point to the start of an element within the slice or to the end of the slice.

The same comment applies to elem_offset but it is more restricted:

Returns None if element does not point to the start of an element within the slice.

I've created a PR (#132830) that includes the documentation changes that you suggested (with some minor modifications) and implements the renaming suggested by @tgross35.