regression: misaligned pointer dereference: address must be a multiple ...

[Mark-Simulacrum]

A bunch of these seem to come from rand_core 0.2.1, 0.3.0, and 0.4.0 code (not sure if we can fix it there?)

• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/BlockchainIdentityLab.zero-knowledge-rust-example/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/BrMallet.grafico/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/BurntSushi.xsv/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/GregBowyer.opentelemetry-rs/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/Keirua.whitespace-rs/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/LesnyRumcajs.rustasano/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/NickCao.ebpf-rs/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/Svetixbot.game_of_pawns/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/Torrencem.braid-crypto/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/Vurich.sexpress/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/aharisu.navi/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/bnewbold.geniza/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/boustrophedon.taskerizer-prototype/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/mmirolim.algorithms/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/pierre-l.spatiub/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/pizzamig.myrello/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/remexre.serde_sexpr/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/yetone.mirdb/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/reg/binstore-0.2.0/log.txt

Not rand_core:

• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/cogman.sav1n/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/d-becker.compressions/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/golddranks.aws_auth/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/heyimalex.bitap/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/jondot.rawsort/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/peterallin.cryptopals/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/pjtatlow.jammdb/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/polygonhell.rusttests/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/poodlenoodle42.Pipeline-Simulator/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/quietvoid.hdr10plus_parser/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/rohankumardubey.wizer/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/rs-embedded.fdt-rs/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/scrogson.scotty/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/senden9.geo_fence/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/sharpjs.cfda/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/uriyatenzer.uriya/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/reg/atoi_simd-0.12.2/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/reg/dtb-0.2.0/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/reg/lowpass-filter-0.3.2/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/reg/lua_bind_hash-1.0.1/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/reg/minilzo3-0.1.0/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/reg/openpgp-card-sequoia-0.1.2/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/reg/quad-image-0.1.1/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/reg/radixt-0.1.0/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/reg/rsmnl-0.1.0/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/reg/sfmt-0.7.0/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/reg/shared-data-0.0.2/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/reg/supercow-0.1.0/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/reg/unicode_converter-0.1.0/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/reg/welch-sde-0.1.0/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/reg/x86-alignment-check-0.1.5/log.txt

cc #98112

[Mark-Simulacrum]

#98112 doesn't seem to have an FCP for doing this, which makes some sense (it's just "exploiting" UB).

@saethlin did we file PRs against the relevant crates which break the most transitive tests at least? e.g., rand_core 0.2.x, 0.3.x, 0.4.x seem to be a good fraction of this list. There's a few more crates that seem to stand out too (e.g., plotters-bitmap).

[saethlin]

We did not make any effort to file fixes for the relevant crates.

The rand_core issue in 0.4 has been patched for about 4 years: rust-random/rand#783 then it looks to me like rand does the semver trick, so I think they pulled the fix into 0.3 and 0.2, based on spot checking.

The plotters-bitmap issue was patched a few weeks ago, it's just not released yet: plotters-rs/plotters#467

[saethlin]

The only things I think are significant are:

An issue in an old version (almost 4 years old) of wasmtime-runtime, https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/rohankumardubey.wizer/log.txt

Multiple crates hitting an issue in kamadak-exif-0.3.1:
https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/reg/quad-image-0.1.1/log.txt
https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/jondot.rawsort/log.txt
https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/senden9.geo_fence/log.txt
This issue was patched 4 years ago in kamadak/exif-rs@288a7e8 but there isn't a semver-compatible update available.

I don't think these are worth doing anything with. All we could do here is ask maintainers to backport fixes.

[Mark-Simulacrum]

Sounds like that's right. The main thing we usually try to ensure is that there is some upgrade path, especially for common code, and I think this covers most of that. Plus it technically won't affect non-debug builds, so users have that escape hatch too.

I'm fine leaving this as-is.