[bug] Calculated average time is stored as integers

[hexathos]

Aloha,

storing average time as integer in the database

panstorm.com/database/migrations/2025_01_16_221857_create_pages_table.php

Line 22 in b4645ab

$table->integer('average_time');

might bite back... Here's why:

It limits resolution of your stats down to full seconds, minutes, whatever unit you are going to store. That is bad, just let us calculate the averagte of two views: One view with 51 seconds duration one with 10 seconds.... (For simplicity, full seconds) those values together make it up to 61 Seconds, with an average of 30.5 seconds, wich you will store as 30 or 31 seconds.

Limiting avarage time to an integer value will destroy relevant stats for your users and for some, it might render those stats as unuseable.

[ke-helle]

In that case I would treat this the same way as currency, and save the value in ms. I dont belive saving it as float is an option.

[hexathos]

Storing that value in milliseconds boosts you into other problems:

maximum integer value in mysql and postgres is 2,147,483,647
a 5 minute avarage renders in 300.000 milliseconds

that means you cannot have more then 7158 rows of that page in a bucket and sum that time up for further calculations. e.g. that means your applicatun kills itself after around 20 years :-) if using daily buckets... less if buckets are hourly or in 15 minute cycles.