Skip to content

make deserializable fields pub #1525

@sunshowers

Description

@sunshowers

Currently we have a number of structs that are:

  • deserializable
  • don't have any kind of validation as part of deserialization
  • have private fields

Generally speaking, private fields like this are misleading, since the fields are defacto public through a constructed serde_json::Value or similar. See for example oxidecomputer/omicron#9723.

We should audit our uses and make the fields either public or accessible via a constructor.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions