Unhandled ObjectExistsException in /plantModel put crashes tcs

[thraen]

Uploading invalid plant models can crash the tcs.

Particularly trying to put model to the /plant_model endpoint with a duplicate path crashes the tcs.

I looked into the code, and if I understand correctly, exceptions in V1RequestHandler.java are more or less not handled.

I feel that that handleXYrequest should catch exceptions and refuse requests. Do you agree, and, if so accept a pull request?

[20250721-23:05:59-235] WARNING kernelExecutor       o.o.common.LoggingScheduledThreadPoolExecutor.afterExecute(): Unhandled exception in executed task
org.opentcs.data.ObjectExistsException: Object name already exists: C-J
	at org.opentcs.kernel.workingset.TCSObjectRepository.addObject(TCSObjectRepository.java:54)
	at org.opentcs.kernel.workingset.PlantModelManager.createPath(PlantModelManager.java:1448)
	at org.opentcs.kernel.workingset.PlantModelManager.createPlantModelObjects(PlantModelManager.java:187)
	at org.opentcs.kernel.services.StandardPlantModelService.createPlantModel(StandardPlantModelService.java:186)
	at org.opentcs.kernel.extensions.servicewebapi.v1.PlantModelHandler.lambda$putPlantModel$0(PlantModelHandler.java:115)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:572)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)

[martingr]

Thank you for reporting the issue. I can confirm that this case doesn't seem to be handled properly in the kernel / web API, yet. We will look into this as soon as time permits.

Contributions to the openTCS project (e.g. in the form of pull requests) are very welcome. If you are planning on contributing, please take a look at the contributing guidelines (CONTRIBUTING.adoc) first and consider creating a proper issue for this.

[thraen]

It seems that I can't open issues, are there access restrictions?

[martingr]

Thank you for pointing that out. There was indeed a problem with creating issues. This has been resolved and you should now be able to create issues again.

[thraen]

Hi,
I just went ahead and made a pull request as a basis for discussion. It's very small, please look whether you generally agree with the approach. if so, I will add tests and whatever you need

#214

[swltr]

@thraen Note that the issue you described here should be fixed by cbb37b3, which is in openTCS 6.6.