Fatal Error while trying to remove items from cart

[antforager]

I noticed this fatal error started 3 days ago and I was just able to reproduce it. If you attempt to remove the item from the shopping cart by clicking on the X, it does nothing.

Here is a video showing what happens

cannot-delete-cart.mp4

Please repro from my staging site: https://6b5.042.myftpupload.com/

The Log that gets generated after clicking on the X:

Fatal error: Uncaught DivisionByZeroError: Division by zero in /var/www/wp-content/mu-plugins/vendor/godaddy/mwc-core/vendor/godaddy/mwc-google-analytics/src/Tracking/Adapters/Cart_Item_Event_Data_Adapter.php:72

Stack Trace
1.	
{anonymous}()
/var/www/wp-content/mu-plugins/vendor/godaddy/mwc-core/vendor/godaddy/mwc-google-analytics/src/Tracking/Adapters/Cart_Item_Event_Data_Adapter.php:72
2.	
GoDaddy\WordPress\MWC\GoogleAnalytics\Tracking\Adapters\Cart_Item_Event_Data_Adapter->convert_from_source()
/var/www/wp-content/mu-plugins/vendor/godaddy/mwc-core/vendor/godaddy/mwc-google-analytics/src/Tracking/Events/GA4/Change_Cart_Quantity_Event.php:95
3.	
GoDaddy\WordPress\MWC\GoogleAnalytics\Tracking\Events\GA4\Change_Cart_Quantity_Event->track('e35fb931db1c8fed423c19...', '0')
/var/www/wp-includes/class-wp-hook.php:326
4.	
WP_Hook->apply_filters(null, Array(4))
/var/www/wp-includes/class-wp-hook.php:348
5.	
WP_Hook->do_action(Array(4))
/var/www/wp-includes/plugin.php:517
6.	
do_action('woocommerce_after_cart...', 'e35fb931db1c8fed423c19...', '0', '1', WC_Cart)
/var/www/wp-content/plugins/woocommerce/includes/class-wc-cart.php:1407
7.	
WC_Cart->set_quantity('e35fb931db1c8fed423c19...', '0')
/var/www/wp-content/themes/bootscore/woocommerce/inc/ajax-cart.php:184
8.	
bootscore_qty_update('')
/var/www/wp-includes/class-wp-hook.php:324
9.	
WP_Hook->apply_filters('', Array(1))
/var/www/wp-includes/class-wp-hook.php:348
10.	
WP_Hook->do_action(Array(1))
/var/www/wp-includes/plugin.php:517
11.	
do_action('wp_ajax_bootscore_qty_...')
/var/www/wp-admin/admin-ajax.php:192

URL	/?wc-ajax=checkout
Referer	https://6b5.042.myftpupload.com/checkout/
HTTP Method	POST
HTTP Host	6b5.042.myftpupload.com
HTTP Status	200
isSSL	Yes
Current Filter	template_redirect, wc_ajax_checkout, woocommerce_order_status_processing
Execution Time	7.293 s
Memory Usage	27.53 MiB
PHP SAPI	cgi-fcgi```

[antforager]

Reference to the line mentioned in the stack trace:

bootscore/woocommerce/inc/ajax-cart.php

Line 184 in a0950be

WC()->cart->set_quantity($cart_item_key, $qty);

[crftwrk]

Downgraded to v6.2.1 and remove button works as expected. It seems to happen here Fixes double cart item removal.

You have many plugins on your site and one of it does something with the remove button. It adds a data-google_product_id attribute and shows a x instead the trash icon. Have you tried to disable all plugins and enable them step-by-step to locate it? This might be very helpful.

@Axos11 any idea?

[antforager]

What I really want to do it start fresh and only install a handful of plugins but I think it would be a big undertaking.

[crftwrk]

I do not think that it's needed to create a new WordPress and import all that stuff to there. If you delete all disabled plugins and unused themes, you will have a much more cleaner page.

For existing plugins: Each plugin pays attention, check if a plugin is really needed and if its not worth to keep it, delete it.

WordPress is not sophisticated, you can quickly move away from GoDaddy to a low priced hoster. There are many migration tools, I use Akeeba Backup for tasks like this for years.

[Axos11]

@crftwrk , godaddy makes some fun stuff there.

Actually i changed the function to remove items from the cart to qty. update to 0 because then we wouldn't need to handle the ajax cart stuff of woocommerce completeley on our own.

Under the hood, woocommerce just removes the item if it is set to 0. It seems that godaddy, doesn't like that behaviour and just doesn't check if the qty is 0 before running their code.

I thought of removing the "Standard" implementation of woocommerce for loading the ajax cart stuff before. and readd the really necessary stuff on our own, but hadn't had time to figure that out.

I mean our approach is not the best, but godaddy not checking for 0 qty isnt either :D

[antforager]

I can put in a request for them to add the check but it may not happen at all or at least not for a while. I know they have replaced some standard WooCommerce files with their own implementation.

[Axos11]

In the error line you posted you see that there is a division by 0. So as quantity is set to 0 there should be something like $variable / $quantity

Fatal error: Uncaught DivisionByZeroError: Division by zero in /var/www/wp-content/mu-plugins/vendor/godaddy/mwc-core/vendor/godaddy/mwc-google-analytics/src/Tracking/Adapters/Cart_Item_Event_Data_Adapter.php:72

I am not at a PC till tomorrow, but you could post the line 72 of that file here. Should make it clearer.

[antforager]

'discount' => NumberUtil::round( ( $item['line_subtotal'] - $item['line_total'] ) / $item['quantity'], wc_get_price_decimals() ),

[antforager]

@Axos11 Do you think we might be able to revisit this? I'm stuck on v6.21 of the theme and there is another bug that was fixed recently in the current version that I would really like to be using.

You can see that it is dividing by $item['quantity'] without checking for 0.

[Axos11]

have you got any response from godaddy? I think they should fix their bug as well.

I do plan to change a few minor details in the qty update processm in gerneral, so maybe that fixes your issue as well. But as said mainly I think it is a godaddy issue.

@crftwrk FYI

[antforager]

I am working with them on this. They have been waiting on me to provide details about when/why the cart item would have a 0 quantity. I just sent them my response. They did give me a workaround that has allowed me to update to the latest Bootscore -- they have a filter that turns off their built-in analytics plugin.

[crftwrk]

#1120

[Axos11]

@antmama The latest Commit should fix that issue. Please let us know if you can activate the analyctics again