You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've been looking into this and have a fix ready. Here's the approach:
Root cause: ShellCommandHandler::base_command() in codex-rs/core/src/tools/handlers/shell.rs hardcodes login.unwrap_or(true), so when no explicit login is passed by the tool call, it always uses a login shell (bash -lc). This re-sources startup scripts and clobbers the inherited PATH, even when shell_environment_policy.inherit = "all" is set.
Fix: Add a [shell] config section with a default_login option:
[shell]
default_login = false
Rules:
Defaults to true when absent (no behavior change for existing users)
Per-invocation login param on the tool call always takes precedence
Threaded through ConfigToml -> Config -> TurnContext -> ShellCommandHandler
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
Related issue: #8922
I've been looking into this and have a fix ready. Here's the approach:
Root cause:
ShellCommandHandler::base_command()incodex-rs/core/src/tools/handlers/shell.rshardcodeslogin.unwrap_or(true), so when no explicitloginis passed by the tool call, it always uses a login shell (bash -lc). This re-sources startup scripts and clobbers the inheritedPATH, even whenshell_environment_policy.inherit = "all"is set.Fix: Add a
[shell]config section with adefault_loginoption:Rules:
truewhen absent (no behavior change for existing users)loginparam on the tool call always takes precedenceConfigToml->Config->TurnContext->ShellCommandHandlerBeta Was this translation helpful? Give feedback.
All reactions