Context
This follow-up task was identified during the review of PR #59.
Source PR: #59
PR Title: feat: add patterns example app — Session 1 (scaffold + forms #1-7)
Suggested by: @Copilot
Comment type: review comment on patterns/patterns_test.go
Task Description
The preserve-inputs test uses e2etest.WaitFor("true", ...) after form submission, which doesn't wait on any specific post-submit condition and can be flaky. The repo's E2E checklist (CLAUDE.md:78-80) recommends condition-based waits.
Proposed fix: Wait for a concrete DOM change (e.g., a success indicator, or the expected input value being present) before reading/asserting field values.
Original Comment
This uses e2etest.WaitFor(true, ...) after form submission, which doesn't wait on any specific post-submit condition and can be flaky. The repo's E2E checklist recommends condition-based waits (CLAUDE.md:78-80). Prefer waiting for a concrete DOM change (e.g., a success indicator, or the expected input value being present) before reading/asserting field values.
e2etest.WaitFor(`document.querySelector('input[name="name"]') !== null && document.querySelector('input[name="name"]').value === "Test Name"`, 3*time.Second),
This issue was automatically created by prmonitor from PR review comments.
Context
This follow-up task was identified during the review of PR #59.
Source PR: #59
PR Title: feat: add patterns example app — Session 1 (scaffold + forms #1-7)
Suggested by: @Copilot
Comment type: review comment on
patterns/patterns_test.goTask Description
The preserve-inputs test uses
e2etest.WaitFor("true", ...)after form submission, which doesn't wait on any specific post-submit condition and can be flaky. The repo's E2E checklist (CLAUDE.md:78-80) recommends condition-based waits.Proposed fix: Wait for a concrete DOM change (e.g., a success indicator, or the expected input value being present) before reading/asserting field values.
Original Comment
This issue was automatically created by prmonitor from PR review comments.