Context
This follow-up task was identified during the review of PR #59.
Source PR: #59
PR Title: feat: add patterns example app — Session 1 (scaffold + forms #1-7)
Suggested by: @Copilot
Comment type: review comment on patterns/patterns_test.go
Task Description
The bulk-update test uses e2etest.WaitFor("true", ...) after clicking Update, which doesn't wait on any meaningful condition and can be flaky (it's effectively a time-based delay). The repo's E2E checklist (CLAUDE.md:78-80) explicitly recommends condition-based waits.
Proposed fix: Wait for a concrete DOM condition that reflects the update (e.g., checked state of active-1/active-3) before asserting.
Original Comment
This uses e2etest.WaitFor(true, ...) after clicking Update, which doesn't wait on a meaningful condition and can be flaky (it's effectively a time-based delay). The repo's E2E checklist explicitly recommends condition-based waits (CLAUDE.md:78-80). Wait for a concrete DOM condition that reflects the update (e.g., checked state of active-1/active-3) before asserting.
// Click Update and wait for the updated checkbox state to be reflected in the DOM
chromedp.Click(`button[name="bulkUpdate"]`, chromedp.ByQuery),
e2etest.WaitFor(`!document.querySelector('input[name="active-1"]').checked && document.querySelector('input[name="active-3"]').checked`, 2*time.Second),
This issue was automatically created by prmonitor from PR review comments.
Context
This follow-up task was identified during the review of PR #59.
Source PR: #59
PR Title: feat: add patterns example app — Session 1 (scaffold + forms #1-7)
Suggested by: @Copilot
Comment type: review comment on
patterns/patterns_test.goTask Description
The bulk-update test uses
e2etest.WaitFor("true", ...)after clicking Update, which doesn't wait on any meaningful condition and can be flaky (it's effectively a time-based delay). The repo's E2E checklist (CLAUDE.md:78-80) explicitly recommends condition-based waits.Proposed fix: Wait for a concrete DOM condition that reflects the update (e.g., checked state of
active-1/active-3) before asserting.Original Comment
This issue was automatically created by prmonitor from PR review comments.