Context
This follow-up task was identified during the review of PR #57.
Source PR: #57
PR Title: refactor: consolidate DevMode blocks with defer, enable skipped test suites
Suggested by: @copilot-pull-request-reviewer
Files: progressive-enhancement/progressive_enhancement_test.go:56 and :620
Task Description
Two server readiness loops use http.Get with the default client (no timeout). If a connection attempt stalls, this can hang the test process in CI.
Fix both locations:
setupServer() (line ~56): Use &http.Client{Timeout: 2 * time.Second} for the probe requests
TestProgressiveEnhancement_DisabledReturnsJSON (line ~620): Same fix
This issue was automatically created from PR review comments.
Context
This follow-up task was identified during the review of PR #57.
Source PR: #57
PR Title: refactor: consolidate DevMode blocks with defer, enable skipped test suites
Suggested by: @copilot-pull-request-reviewer
Files:
progressive-enhancement/progressive_enhancement_test.go:56and:620Task Description
Two server readiness loops use
http.Getwith the default client (no timeout). If a connection attempt stalls, this can hang the test process in CI.Fix both locations:
setupServer()(line ~56): Use&http.Client{Timeout: 2 * time.Second}for the probe requestsTestProgressiveEnhancement_DisabledReturnsJSON(line ~620): Same fixThis issue was automatically created from PR review comments.