Data inconsistency between blockchain and contracts/disputes

[ashishjur]

Expected Behavior

Data in JBP's contracts/disputes tables should be in sync with blockchain.

Current Behavior

In case the transaction fails, data on DB is different than that of on blockhain.

Possible Solution

Steps to Reproduce

Environment: Dev

Branch release/0.9.4 commit 318593c

1. Create a contract
2. Open a dispute
3. Try to amend dispute. It will show gas estimate 5. Run the transaction. It will fail.
4. Do step 3 few times. Refresh page.

Now you have data in DB about amendments of dispute proposals but not on blockchain as transactions failed.
This flow serves purpose of reaching data inconsistancy. There could be other such cases mainly due to nature of how tata is propogated in JBP's contracts/disputes tables and blockchain.

PS: Actual bug of gas estimate 5 has been fixed in later commits.