From 2362849eefc3c39396321669e9d930564c948331 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Sun, 15 Feb 2026 19:03:13 +0000 Subject: [PATCH 1/4] build(deps): bump golang.org/x/mod from 0.31.0 to 0.33.0 Bumps [golang.org/x/mod](https://github.com/golang/mod) from 0.31.0 to 0.33.0. - [Commits](https://github.com/golang/mod/compare/v0.31.0...v0.33.0) --- updated-dependencies: - dependency-name: golang.org/x/mod dependency-version: 0.33.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- go.mod | 2 +- go.sum | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/go.mod b/go.mod index 1c353b2..0016d3c 100644 --- a/go.mod +++ b/go.mod @@ -8,7 +8,7 @@ require ( github.com/creack/pty v1.1.24 github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51 github.com/mitchellh/go-homedir v1.1.0 - golang.org/x/mod v0.31.0 + golang.org/x/mod v0.33.0 golang.org/x/term v0.40.0 modernc.org/sqlite v1.40.1 ) diff --git a/go.sum b/go.sum index 784c9ac..b8d92d7 100644 --- a/go.sum +++ b/go.sum @@ -43,8 +43,8 @@ github.com/xo/terminfo v0.0.0-20220910002029-abceb7e1c41e h1:JVG44RsyaB9T2KIHavM github.com/xo/terminfo v0.0.0-20220910002029-abceb7e1c41e/go.mod h1:RbqR21r5mrJuqunuUZ/Dhy/avygyECGrLceyNeo4LiM= golang.org/x/exp v0.0.0-20250620022241-b7579e27df2b h1:M2rDM6z3Fhozi9O7NWsxAkg/yqS/lQJ6PmkyIV3YP+o= golang.org/x/exp v0.0.0-20250620022241-b7579e27df2b/go.mod h1:3//PLf8L/X+8b4vuAfHzxeRUl04Adcb341+IGKfnqS8= -golang.org/x/mod v0.31.0 h1:HaW9xtz0+kOcWKwli0ZXy79Ix+UW/vOfmWI5QVd2tgI= -golang.org/x/mod v0.31.0/go.mod h1:43JraMp9cGx1Rx3AqioxrbrhNsLl2l/iNAvuBkrezpg= +golang.org/x/mod v0.33.0 h1:tHFzIWbBifEmbwtGz65eaWyGiGZatSrT9prnU8DbVL8= +golang.org/x/mod v0.33.0/go.mod h1:swjeQEj+6r7fODbD2cqrnje9PnziFuw4bmLbBZFrQ5w= golang.org/x/sync v0.16.0 h1:ycBJEhp9p4vXvUZNszeOq0kGTPghopOL8q0fq3vstxw= golang.org/x/sync v0.16.0/go.mod h1:1dzgHSNfp02xaA81J2MS99Qcpr2w7fw1gpm99rleRqA= golang.org/x/sys v0.6.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= @@ -52,8 +52,8 @@ golang.org/x/sys v0.41.0 h1:Ivj+2Cp/ylzLiEU89QhWblYnOE9zerudt9Ftecq2C6k= golang.org/x/sys v0.41.0/go.mod h1:OgkHotnGiDImocRcuBABYBEXf8A9a87e/uXjp9XT3ks= golang.org/x/term v0.40.0 h1:36e4zGLqU4yhjlmxEaagx2KuYbJq3EwY8K943ZsHcvg= golang.org/x/term v0.40.0/go.mod h1:w2P8uVp06p2iyKKuvXIm7N/y0UCRt3UfJTfZ7oOpglM= -golang.org/x/tools v0.39.0 h1:ik4ho21kwuQln40uelmciQPp9SipgNDdrafrYA4TmQQ= -golang.org/x/tools v0.39.0/go.mod h1:JnefbkDPyD8UU2kI5fuf8ZX4/yUeh9W877ZeBONxUqQ= +golang.org/x/tools v0.41.0 h1:a9b8iMweWG+S0OBnlU36rzLp20z1Rp10w+IY2czHTQc= +golang.org/x/tools v0.41.0/go.mod h1:XSY6eDqxVNiYgezAVqqCeihT4j1U2CCsqvH3WhQpnlg= modernc.org/cc/v4 v4.26.5 h1:xM3bX7Mve6G8K8b+T11ReenJOT+BmVqQj0FY5T4+5Y4= modernc.org/cc/v4 v4.26.5/go.mod h1:uVtb5OGqUKpoLWhqwNQo/8LwvoiEBLvZXIQ/SmO6mL0= modernc.org/ccgo/v4 v4.28.1 h1:wPKYn5EC/mYTqBO373jKjvX2n+3+aK7+sICCv4Fjy1A= From c2558f9c19199f75b9a13a2708d576e439714809 Mon Sep 17 00:00:00 2001 From: Joel Klabo Date: Mon, 2 Mar 2026 16:23:36 -0800 Subject: [PATCH 2/4] Fix SQLite test file permission cleanup issue - Add permission fix step before PTY tests - Set proper file/directory permissions in go module cache - Fixes permission denied errors during SQLite test cleanup - Addresses CI failures on macOS/Windows test runners --- .github/workflows/ci.yml | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8cf5956..f882072 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -48,7 +48,16 @@ jobs: if: matrix.os != 'ubuntu-latest' run: go test ./... - - name: PTY integration tests + - name: Fix SQLite test file permissions (cleanup) + if: always() && runner.os != 'Windows' + run: | + # Fix permissions on SQLite test files in go module cache + if [ -d "$HOME/.ci-tmp-home/go/pkg/mod/modernc.org/sqlite@"* ]; then + find "$HOME/.ci-tmp-home/go/pkg/mod/modernc.org/sqlite@"* -type f -exec chmod 644 {} + 2>/dev/null || true + find "$HOME/.ci-tmp-home/go/pkg/mod/modernc.org/sqlite@"* -type d -exec chmod 755 {} + 2>/dev/null || true + fi + + - name: PTY-integration tests if: runner.os != 'Windows' run: go test ./... -run TestPTY -count=1 From c9db1c5d0e7e10ac3ecd6428b11e91158f29d9e9 Mon Sep 17 00:00:00 2001 From: Joel Klabo Date: Mon, 2 Mar 2026 16:51:55 -0800 Subject: [PATCH 3/4] fix: resolve actionlint error and SQLite test permission issues - Replace glob pattern test in if condition with proper for loop - Add proactive SQLite file permission fixes before tests run - Ensures both actionlint compliance and test stability --- .github/workflows/ci.yml | 23 +++++++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f882072..479d6a0 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -40,6 +40,19 @@ jobs: if: runner.os != 'Windows' run: scripts/ci/install_agent_clis.sh + - name: Fix SQLite test file permissions (proactive) + if: runner.os != 'Windows' + run: | + # Download dependencies first to ensure SQLite module is cached + go mod download + # Fix permissions on SQLite test files in go module cache + for sqlite_dir in "$HOME/.ci-tmp-home/go/pkg/mod/modernc.org/sqlite@"*; do + if [ -d "$sqlite_dir" ]; then + find "$sqlite_dir" -type f -exec chmod 644 {} + 2>/dev/null || true + find "$sqlite_dir" -type d -exec chmod 755 {} + 2>/dev/null || true + fi + done + - name: Test (with coverage on ubuntu) if: matrix.os == 'ubuntu-latest' run: go test ./... -coverprofile=coverage.out -covermode=atomic @@ -52,10 +65,12 @@ jobs: if: always() && runner.os != 'Windows' run: | # Fix permissions on SQLite test files in go module cache - if [ -d "$HOME/.ci-tmp-home/go/pkg/mod/modernc.org/sqlite@"* ]; then - find "$HOME/.ci-tmp-home/go/pkg/mod/modernc.org/sqlite@"* -type f -exec chmod 644 {} + 2>/dev/null || true - find "$HOME/.ci-tmp-home/go/pkg/mod/modernc.org/sqlite@"* -type d -exec chmod 755 {} + 2>/dev/null || true - fi + for sqlite_dir in "$HOME/.ci-tmp-home/go/pkg/mod/modernc.org/sqlite@"*; do + if [ -d "$sqlite_dir" ]; then + find "$sqlite_dir" -type f -exec chmod 644 {} + 2>/dev/null || true + find "$sqlite_dir" -type d -exec chmod 755 {} + 2>/dev/null || true + fi + done - name: PTY-integration tests if: runner.os != 'Windows' From aee6e0abedac5b2fda41187253461c9069885db7 Mon Sep 17 00:00:00 2001 From: Joel Klabo Date: Mon, 2 Mar 2026 17:52:45 -0800 Subject: [PATCH 4/4] fix: move git shim install after integration to avoid temp dir issues --- scripts/ci/agent_cli_smoke.sh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/scripts/ci/agent_cli_smoke.sh b/scripts/ci/agent_cli_smoke.sh index 1f09968..314e4c6 100755 --- a/scripts/ci/agent_cli_smoke.sh +++ b/scripts/ci/agent_cli_smoke.sh @@ -16,8 +16,6 @@ export HOME="$tmp_home" echo echo "Using HOME=$HOME" -go run ./cmd/ackchyually shim install git - echo echo "Integrate status (before):" go run ./cmd/ackchyually integrate status @@ -30,6 +28,9 @@ echo echo "Integrate status (after):" go run ./cmd/ackchyually integrate status +# Install git shim after integration to avoid temp dir issues +go run ./cmd/ackchyually shim install git + echo echo "Verify:" go run ./cmd/ackchyually integrate verify all