From 74577f71a133bce83c3b075018adf7f679a38ab5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9lestin=20Matte?= Date: Tue, 14 Apr 2026 10:38:06 +0200 Subject: [PATCH] Bugfix: properly activate and deactivate fps fields when necessary movieRecording is not initialized yet and isChecked() does not return an accurate value at that point in the code. As a fix, we activate the fields by default and deactivate them on movie load. --- src/program/ui/MainWindow.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/program/ui/MainWindow.cpp b/src/program/ui/MainWindow.cpp index 6726b99c..2375c370 100644 --- a/src/program/ui/MainWindow.cpp +++ b/src/program/ui/MainWindow.cpp @@ -240,7 +240,7 @@ MainWindow::MainWindow(Context* c) : QMainWindow(), context(c) fpsNumField = new QSpinBox(); fpsNumField->setMaximum(std::numeric_limits::max()); fpsNumField->setMinimum(1); - fpsNumField->setEnabled(movieRecording->isChecked()); + fpsNumField->setEnabled(true); disabledWidgetsOnStart.append(fpsNumField); connect(fpsNumField, QOverload::of(&QSpinBox::valueChanged),[=, this](int i){ context->current_framerate_num = i; @@ -250,7 +250,7 @@ MainWindow::MainWindow(Context* c) : QMainWindow(), context(c) fpsDenField = new QSpinBox(); fpsDenField->setMaximum(std::numeric_limits::max()); fpsDenField->setMinimum(1); - fpsDenField->setEnabled(movieRecording->isChecked()); + fpsDenField->setEnabled(true); disabledWidgetsOnStart.append(fpsDenField); connect(fpsDenField, QOverload::of(&QSpinBox::valueChanged),[=, this](int i){ context->current_framerate_den = i; @@ -1021,6 +1021,8 @@ void MainWindow::updateMovieParams() authorField->setText(gameLoop->movie.header->authors.c_str()); fpsNumField->setValue(context->config.sc.initial_framerate_num); fpsDenField->setValue(context->config.sc.initial_framerate_den); + fpsNumField->setEnabled(movieRecording->isChecked()); + fpsDenField->setEnabled(movieRecording->isChecked()); elapsedTimeSec->setValue(context->config.sc.initial_monotonic_time_sec); elapsedTimeNsec->setValue(context->config.sc.initial_monotonic_time_nsec); realTimeSec->setValue(context->config.sc.initial_time_sec);