Core task detect_github_repo_move_secondary - NoResultFound('No row was found when one was required')

[cdolfi]

Sample of repos this is happening on :
https://github.com/docker/engine-sync
https://github.com/hil-se/idai-720-assignments
https://github.com/docker/marked
https://github.com/eclipse/agileuml
https://github.com/eclipse/jnosql-aphrodite

Exception | NoResultFound('No row was found when one was required')

Stack Trace

Traceback (most recent call last):
  File "/augur/.venv/lib/python3.11/site-packages/celery/app/trace.py", line 453, in trace_task
    R = retval = fun(*args, **kwargs)
                 ^^^^^^^^^^^^^^^^^^^^
  File "/augur/.venv/lib/python3.11/site-packages/celery/app/trace.py", line 736, in __protected_call__
    return self.run(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/augur/augur/tasks/github/detect_move/tasks.py", line 57, in detect_github_repo_move_secondary
    ping_github_for_repo_move(session, key_auth, repo, logger,collection_hook='secondary')
  File "/augur/augur/tasks/github/detect_move/core.py", line 112, in ping_github_for_repo_move
    raise RepoMovedException("ERROR: Repo has moved! Resetting Collection!", new_url=new_url)
augur.tasks.github.detect_move.core.RepoMovedException: ERROR: Repo has moved! Resetting Collection!

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/augur/.venv/lib/python3.11/site-packages/celery/app/trace.py", line 470, in trace_task
    I, R, state, retval = on_error(task_request, exc)
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/augur/.venv/lib/python3.11/site-packages/celery/app/trace.py", line 381, in on_error
    R = I.handle_error_state(
        ^^^^^^^^^^^^^^^^^^^^^
  File "/augur/.venv/lib/python3.11/site-packages/celery/app/trace.py", line 175, in handle_error_state
    return {
           ^
  File "/augur/.venv/lib/python3.11/site-packages/celery/app/trace.py", line 233, in handle_failure
    task.on_failure(exc, req.id, req.args, req.kwargs, einfo)
  File "/augur/augur/tasks/init/celery_app.py", line 128, in on_failure
    self.augur_handle_task_failure(exc, task_id, repo_git, "secondary_task_failure",collection_hook='secondary')
  File "/augur/augur/tasks/init/celery_app.py", line 90, in augur_handle_task_failure
    repo = session.query(Repo).filter(Repo.repo_git == repo_git).one()
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/augur/.venv/lib/python3.11/site-packages/sqlalchemy/orm/query.py", line 2798, in one
    return self._iter().one()  # type: ignore
           ^^^^^^^^^^^^^^^^^^
  File "/augur/.venv/lib/python3.11/site-packages/sqlalchemy/engine/result.py", line 1827, in one
    return self._only_one_row(
           ^^^^^^^^^^^^^^^^^^^
  File "/augur/.venv/lib/python3.11/site-packages/sqlalchemy/engine/result.py", line 760, in _only_one_row
    raise exc.NoResultFound(
sqlalchemy.exc.NoResultFound: No row was found when one was required

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/augur/.venv/lib/python3.11/site-packages/billiard/pool.py", line 362, in workloop
    result = (True, prepare_result(fun(*args, **kwargs)))
                                   ^^^^^^^^^^^^^^^^^^^^
  File "/augur/.venv/lib/python3.11/site-packages/celery/app/trace.py", line 651, in fast_trace_task
    R, I, T, Rstr = tasks[task].__trace__(
                    ^^^^^^^^^^^^^^^^^^^^^^
  File "/augur/.venv/lib/python3.11/site-packages/celery/app/trace.py", line 574, in trace_task
    I, _, _, _ = on_error(task_request, exc)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/augur/.venv/lib/python3.11/site-packages/celery/app/trace.py", line 381, in on_error
    R = I.handle_error_state(
        ^^^^^^^^^^^^^^^^^^^^^
  File "/augur/.venv/lib/python3.11/site-packages/celery/app/trace.py", line 175, in handle_error_state
    return {
           ^
  File "/augur/.venv/lib/python3.11/site-packages/celery/app/trace.py", line 233, in handle_failure
    task.on_failure(exc, req.id, req.args, req.kwargs, einfo)
  File "/augur/augur/tasks/init/celery_app.py", line 128, in on_failure
    self.augur_handle_task_failure(exc, task_id, repo_git, "secondary_task_failure",collection_hook='secondary')
  File "/augur/augur/tasks/init/celery_app.py", line 90, in augur_handle_task_failure
    repo = session.query(Repo).filter(Repo.repo_git == repo_git).one()
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/augur/.venv/lib/python3.11/site-packages/sqlalchemy/orm/query.py", line 2798, in one
    return self._iter().one()  # type: ignore
           ^^^^^^^^^^^^^^^^^^
  File "/augur/.venv/lib/python3.11/site-packages/sqlalchemy/engine/result.py", line 1827, in one
    return self._only_one_row(
           ^^^^^^^^^^^^^^^^^^^
  File "/augur/.venv/lib/python3.11/site-packages/sqlalchemy/engine/result.py", line 760, in _only_one_row
    raise exc.NoResultFound(
sqlalchemy.exc.NoResultFound: No row was found when one was required

[MoralCode]

so this secondary move task seems to be failing because the repo was already moved
i looked at one of them for https://github.com/llm-d-incubation/inferno-autoscaler and its erroring because it cant find that url in the repo table because its in the historical table

i.e. secondary is getting scheduled at the same time as core and so both the move check tasks are getting run with the old url when only one needs to run to update the repo table.

why do we need two move tasks? especially if we are going to put secondary after core (per #3707 )

I could update the task to handle this exception by basically ignoring it too.

[MoralCode]

also this error is actually happening in the (kinda weirdly built) error handler we have in celery

[MoralCode]

ok so my problem here is this move detection needs a way to be able to reset/re-trigger collection for the repo under the new url if a move is detected. thats the jankest part of it right now.

Can we maybe pull this task out and have it be a single task that is a prerequisite for both core and secondary?