From dff80ff1f9cc9a6a6de90f632d09043be6afe5b3 Mon Sep 17 00:00:00 2001 From: Izaak Schroeder Date: Fri, 19 Jan 2018 16:09:44 -0800 Subject: [PATCH] Support `null` and `string` rendered values. Closes https://github.com/bruderstein/unexpected-react/issues/16. --- .../unexpected-react-testrenderer.spec.js | 12 +++++++++++- src/types/types.js | 3 ++- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/src/tests/testRenderer/unexpected-react-testrenderer.spec.js b/src/tests/testRenderer/unexpected-react-testrenderer.spec.js index 030c38d..d96f5a9 100644 --- a/src/tests/testRenderer/unexpected-react-testrenderer.spec.js +++ b/src/tests/testRenderer/unexpected-react-testrenderer.spec.js @@ -92,7 +92,17 @@ describe('unexpected-react (test renderer)', function () { const comp = ReactTestRenderer.create(hi} />); expect(comp, 'to have rendered',
hi
); }); - + + it('works with strings', function () { + const comp = ReactTestRenderer.create(() => 'foo'); + expect(comp, 'to have rendered', 'foo'); + }); + + it('works with nulls', function () { + const comp = ReactTestRenderer.create(() => null); + expect(comp, 'to have rendered', null); + }); + it('highlights the error if the content does not match', function () { const comp = ReactTestRenderer.create(hi} />); diff --git a/src/types/types.js b/src/types/types.js index 80e3766..b7de13c 100644 --- a/src/types/types.js +++ b/src/types/types.js @@ -20,8 +20,9 @@ function installInto(expect) { identify: function (value) { return React.isValidElement(value) || + value === null || + typeof value === 'string' || (typeof value === 'object' && - value !== null && (typeof value.type === 'function' || typeof value.type === 'string') && typeof value.hasOwnProperty === 'function' && value.hasOwnProperty('props') &&