Skip to content

Update Style Dictionary #661

@mkernohanbc

Description

@mkernohanbc

We are stuck a couple of minor versions back on style-dictionary, until we can diagnose and resolve a new issue that crops up in the build process when we use v5.4.0:

I'm getting erroneous output when switching between these versions after running the build script and examining the output. Let's break the design-tokens changes out to another branch to diagnose.

With style-dictionary 5.2.0:

// variables.css
--typography-regular-display: 400 3rem/AUTO 'BC Sans'; /** Extra-large body text size. Do not use for headings */

With the new style-dictionary 5.4.0:

// variables.css
  --typography-regular-display: 400 3rem/NaNAUTO 'BC Sans'; /** Extra-large body text size. Do not use for headings */
                                         ^^^

See the NaN getting prepended to AUTO above.

We should add a specific test for these composite font checks that use AUTO, similar to this one for --theme-blue-100.

Originally posted by @ty2k in #655 (comment)

Metadata

Metadata

Assignees

Labels

DependenciesChanges or issues affecting dependenciesDesign tokensChanges affecting the design-tokens package
No fields configured for Feature.

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions