Arbitrary service_name length limit

[RobinBol]

Hi, what is the reason for ensuring the service_name length does not exceed 15 chars?

• node_mdns/lib/service_type.js

  Lines 160 to 161 in 43f7256

  	throw new Error('type ' + str + ' has more than 15 characters');
  	}

• node_mdns/lib/service_type.js

  Line 174 in 43f7256

  throw new Error('type ' + _uu(str) + ' has more than 15 characters');

It seems rather arbitrary to me. I am running into issues for service_name's longer than 15 chars. Removing the checks above just seems to work as expected, it discovers the services.

[agnat]

It's a requirement from RFC 6335. Also see http://files.dns-sd.org/draft-cheshire-dnsext-dns-sd.txt

[RobinBol]

Thanks for the quick reply! Unfortunately there are devices around with longer service names. Android TV's for example use a name with 16 chars (excluding leading underscore). They can be discovered on my Mac using Discovery (see below). Any chance that you would consider relaxing the 15 char limit somewhat?

It also seems the avahi-daemon has no problem discovering the longer service names.

[agnat]

Increasing the max length is not a solution. While it works for this string it will fail for others. This is uff-8 and a character may require up to 32 bits.

I might take a PR that turns the max length (and the charset) into a user setting. That way people can work around illegal identifiers but not without noticing that something is fishy.