test(integration): revenue-tracking — fuller stripe-client webhook mock

[bokelley]

Context

Spawned from #3289 / #3313. server/tests/integration/revenue-tracking.test.ts is describe.skip — every test fails with 400 Stripe not configured because the existing mock sets stripe: null while the webhook route requires a non-null Stripe instance to verify signatures.

Fix path

Two reasonable options:

1. Build a fuller stripe-client mock that exposes:

   • stripe.webhooks.constructEvent(body, sig, secret) — should pass through a parsed JSON body during tests
   • stripe.invoices.retrieve(...) and friends as the webhook handlers need
   • STRIPE_WEBHOOK_SECRET set to a non-null fixture

   Pattern reference: server/tests/integration/admin-sync-revenue-backfill.test.ts (after test(integration): un-skip 11 of 13 stale integration files (#3289) #3313) shows how to share fixture state across vi.mock factories using vi.hoisted.

2. Move revenue-tracking integration tests down to the database layer — drop the HTTP webhook framing and exercise the DB helpers directly with handcrafted invoice payloads. Loses the route-handler signature path but is easier to keep alive across SDK changes.

Acceptance

• describe.skip('Revenue Tracking Integration Tests', ...) becomes describe(...) and all 13 tests pass against npm run test:server-integration with a local Postgres.

Related

• Umbrella: Integration tests: stale skips for #3094 — surface and fix #3289
• Cleanup PR that documented this: test(integration): un-skip 11 of 13 stale integration files (#3289) #3313

[bokelley]

Triage

Classification: Bug (test infrastructure)
Bucket(s): admin / ops tools (server billing integration tests)
Status: drafting-pr

What the experts said:

• code-reviewer: Option A (fuller vi.mock) is unambiguously correct; the stale beforeAll dead-code block must be removed atomically (becomes a mock-overwrite bug after the mock is added); STRIPE_WEBHOOK_SECRET must be a truthy string, not null
• internal-tools-strategist: Option A preserves route-handler coverage (signature guard → event dispatch → DB write), which is exactly the billing-pipeline signal we want; Option B (DB-layer tests) loses that coverage permanently

My take: The fix is a textbook vi.hoisted + vi.mock — the identical pattern is already proven by admin-sync-revenue-backfill.test.ts (#3313). Drafting PR now.

Draft PR: #3327 — adds the stripe-client mock, removes the stale dead-code block, removes describe.skip. The TODO comment about the admin stats route was stale: setupStatsRoutes is mounted unconditionally in setupRoutes(), so those tests should also run.

---

Triaged by Claude Code. Session: https://claude.ai/code/session_01DZZ43na714gw4EYgJ5dJUQ

---

Generated by Claude Code