test_HOTP fails for Nitrokey Pro: Unknown Command Authorize

[robinkrahl]

With the current master (f9f8958), the test_HOTP test fails for my Nitrokey Pro:

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test_HOTP is a Catch v2.1.1 host application.
Run with -? for options

-------------------------------------------------------------------------------
Test HOTP codes according to RFC
-------------------------------------------------------------------------------
/home/robin/reps/libnitrokey/unittest/test_HOTP.cc:57
...............................................................................

/home/robin/reps/libnitrokey/unittest/test_HOTP.cc:57: FAILED:
  {Unknown expression after the reported line}
due to unexpected exception with message:
  Command execution has failed on device

===============================================================================
test cases: 2 | 1 passed | 1 failed
assertions: 5 | 4 passed | 1 failed

Relevant log output:

[Thu Apr  5 11:15:41 2018][DEBUG_L1]	=> AUTHORIZE
[Thu Apr  5 11:15:41 2018][DEBUG_L1]	<= AUTHORIZE 0 0
[Thu Apr  5 11:15:41 2018][DEBUG]	Incoming HID packet:
[Thu Apr  5 11:15:41 2018][DEBUG]	Device status:	0 OK
Command ID:	AUTHORIZE hex: 8
Last command CRC:	3d2e8891
Last command status:	9 STICK10::COMMAND_STATUS::UNKNOWN_COMMAND
CRC:	39301db5
Payload:
Empty Payload.
[Thu Apr  5 11:15:41 2018][DEBUG_L1]	Throw: CommandFailedException 9
[Thu Apr  5 11:15:41 2018][DEBUG]	CommandFailedException, status: 9
[Thu Apr  5 11:15:41 2018][DEBUG_L1]	Disconnection: handle already freed: 0 ()

[szszszsz]

Hi!
AUTHORIZE command was removed in Pro v0.8 thus the test is working with Pro v0.7 only. Test uses lower C++ API (that is it operates directly on Command structures instead of using user C++ API by NitrokeyManager class) hence it lacks of device firmware detection and is not adjusting used commands' types to the device (which is implemented in the latter).
I will mention that in the test's documentation and/or add support for the v0.8 to the test implementation. I need to review all the C++ tests as well, since they might be a bit outdated or case specific (they were mainly used to test internals), but not well documented.
Please see this header for user C++ API. It lacks function documentation, but I should correct that in near time.
Meanwhile while in the topic of tests, Python's tests use C API to communicate - perhaps this could give you some insights during your development, which should translate to C++ API as well.

• Update C++ API header (NitrokeyManager.h)
• Update tests' documentation
• Support Pro v0.8 in test_HOTP or make separate test file using user C++ API
• Update other C++ tests or create new using user C++ API

[robinkrahl]

Thanks for the explanations! I already digged deep into NitrokeyManager.{h,cc} and NK_C_API.{h,cc}. Yet I tried to debug a command execution error when configuring HOTP slots, so I happened to execute this test and saw that it failed (while the Python tests passed). Feel free to close this issue as this is expected behavior for my Nitrokey version.