Validate is not failing products with reserved names

[jstone-psi]

Checked for duplicates

Yes - I've already checked

🐛 Describe the bug

When validating the attached collection, the collection_overview.xml label passes validation even though the name collection_*.xml is reserved. This is not a collection label, since the actual collection label is collection_data.xml

🕵️ Expected behavior

I expected the collection_overview.xml label to fail with an error indicating that the name is reserved.

📜 To Reproduce

Using the attached data:

Run the validator:

validate --skip-content-validation -t reserved_not_failing

Observe that collection_overview.xml passes:

  PASS: file:/Users/jessestone/Desktop/neese-validate-20251216/reserved_not_failing/data/collection_overview.xml (urn:nasa:pds:orex.derived_radio_science:data:collection_overview::1.0)
      WARNING  [warning.label.context_ref_mismatch]   line 35: Context reference name mismatch. Value: 'Origins, Spectral Interpretation, Resource Identification, Security, Regolith Explorer (OSIRIS-REx)' Expected one of: '[orex, The Origins, Spectral Interpretation, Resource Identification, Security, Regolith Explorer (OSIRIS-REx) Mission, OSIRIS-REx, Origins, Spectral Interpreation, Resource Identification, Security, Regolith Explorer (OSIRIS-REx) Mission]'
      WARNING  [warning.label.context_ref_mismatch]   line 45: Context reference name mismatch. Value: 'OSIRIS-REx Spacecraft' Expected one of: '[orex, Origins, Spectral Interpreation, Resource Identification, Security, Regolith Explorer (OSIRIS-REx) Spacecraft, The Origins, Spectral Interpretation, Resource Identification, Security, Regolith Explorer (OSIRIS-REx) Spacecraft, OSIRIS-REx]'
      WARNING  [warning.label.context_ref_mismatch]   line 61: Context reference name mismatch. Value: 'Touch-and-Go Camera Suite (TAGCAMS)' Expected one of: '[TAGCAMS, The Touch-and-Go Camera Suite (TAGCAMS) aboard the OSIRIS-REx spacecraft]'
      WARNING  [warning.label.context_ref_mismatch]   line 69: Context reference name mismatch. Value: 'OSIRIS_REx Camera Suite (OCAMS)' Expected one of: '[The OSIRIS-REx Camera Suite (OCAMS) aboard the OSIRIS-REx spacecraft, OCAMS, The OSIRIS-REx Camera Suite Suite (OCAMS) aboard the OSIRIS-REx spacecraft]'
        3 product validation(s) completed

🖥 Environment Info

Ubuntu Linux 22.04
Java 17

📚 Version of Software Used

validate-4.0.8

🩺 Test Data / Additional context

reserved_not_failing.zip

reserved_not_failing.txt

🦄 Related requirements

🦄 #xyz

⚙️ Engineering Details

No response

🎉 Integration & Test

No response

[tbarnes4]

I would like to have some clarity on this since we have two active missions using collection_overview.{xml,lblx} file to point to collection_overview.{pdf,docx,txt} files.

[tbarnes4]

I also noticed that an old bug #561 was resolved where we had the opposite issue, where "collection" was not included in the label name.