Validator Error on empty class in explicit module without a requires on EB

[LexManos]

While poking a FG issue I had to make an empty class:

package com.example.examplemod;
public final class ExampleMod { }

which resulted in an validation error:

Caused by: java.lang.NullPointerException: Cannot invoke "javax.lang.model.element.TypeElement.asType()" because the return value of "javax.lang.model.util.Elements.getTypeElement(java.lang.CharSequence)" is null
        at net.minecraftforge.eventbus.validator.AbstractValidator.init(AbstractValidator.java:74)
        at net.minecraftforge.eventbus.validator.EventBusValidator.init(EventBusValidator.java:33)

[PaintNinja]

Is EventBus on the compile classpath? The line it's failing on is where it grabs the javac type object that the validator needs in order to do inheritance checks:

EventBus/eventbus-validator/src/main/java/net/minecraftforge/eventbus/validator/AbstractValidator.java

Line 74 in e2e1a16

EventTypes.inheritableEvent = elements.getTypeElement(InheritableEvent.class.getCanonicalName()).asType();

Is this on Java 21 or 25? I vaguely remember 25 doing some changes to how APs are loaded, maybe something about needing to put EventBus on the AP classpath on top of implementation.

[LexManos]

That would be a no, and makes sense.
I was working on the vanilla issue you reported. So i changed the MC dep to vanilla and didn't notice i left the AP in.

[basdxz]

This issue seems to happen in 7.0.1, if a project has a module-info.java is present but does not include requires net.minecraftforge.eventbus (or requires on some other module that has requires transitive net.minecraftforge.eventbus).

So it seems that the error more has to do with the module not being imported, so it would be nice for a more clear message rather than a fix.

gradle_log.txt

FunnyEB7.zip

[Jonathing]

If that's the case, this issue could have some sort of check in a ForgeGradle 7 flow action that makes the error easier to understand. I don't think there will be an easy way of making an nice error just from the annotation processor. Unless someone else has a better idea.

[LexManos]

Just to double check, upload a log with --debug to alteast make sure that EB is on the classapth.
But yes, an additional check to detect this case (EB not being on the AP classpath) from the AP instead of NPEing would be a good idea.

[Jonathing]

--info should be enough for Gradle logs. Please don't post debug logs as they can contain unencrypted keys.

[LexManos]

Fair enough, didnt know what level they shove the classpath on.