Fix Storage's storeSize calculation when overwriting existing key#1095
Merged
rbri merged 1 commit intoHtmlUnit:masterfrom Mar 12, 2026
Merged
Fix Storage's storeSize calculation when overwriting existing key#1095rbri merged 1 commit intoHtmlUnit:masterfrom
rbri merged 1 commit intoHtmlUnit:masterfrom
Conversation
|
Member
|
Thanks a lot, have added also a test for that, all works fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR does the following
Fix
Storage.setItemto correctly calculate store size when overwriting an existing key.Problem
When
setItemis called with a key that already exists, the store size calculation only adds the new value's length without subtracting the old value's length. This causesstoreSize_to grow monotonically even when the actual stored data size stays the same or shrinks, eventually triggering a spuriousQuotaExceededError.Reproducing
After enough overwrites,
storeSize_exceedsSTORE_SIZE_KIMITeven though the store only holds a single small value.