From 86957b5707238abe85399fa3af9bbc00dc507b2f Mon Sep 17 00:00:00 2001 From: Nicole Gray Date: Mon, 6 Apr 2026 11:21:13 -0500 Subject: [PATCH 01/19] add underlines to links, remove from buttons --- app/assets/stylesheets/style.scss.erb | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/app/assets/stylesheets/style.scss.erb b/app/assets/stylesheets/style.scss.erb index 794a2b3..e88b49d 100644 --- a/app/assets/stylesheets/style.scss.erb +++ b/app/assets/stylesheets/style.scss.erb @@ -589,3 +589,22 @@ pre code { */ blockquote {font-size: 1em;} + +/* a11y changes */ + +a { + text-decoration: underline; +} + +a:hover { + text-decoration-thickness: 2px; +} + +a.btn, +a.btn:hover { + text-decoration: none; +} + +.btn { + white-space: initial; +} \ No newline at end of file From a69fb8bdd9d05305b9094f0a1ebed55552734fc9 Mon Sep 17 00:00:00 2001 From: Nicole Gray Date: Mon, 6 Apr 2026 11:45:14 -0500 Subject: [PATCH 02/19] add lang attr to html element --- app/views/layouts/application.html.erb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb index 4974339..0054b73 100644 --- a/app/views/layouts/application.html.erb +++ b/app/views/layouts/application.html.erb @@ -1,5 +1,5 @@ - + Austen From 79c73a4c8ce09a46b3e4a280f808f8f4a3aa6016 Mon Sep 17 00:00:00 2001 From: Nicole Gray Date: Mon, 6 Apr 2026 11:46:21 -0500 Subject: [PATCH 03/19] shift div to header landmark --- app/views/layouts/application.html.erb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb index 0054b73..52b7071 100644 --- a/app/views/layouts/application.html.erb +++ b/app/views/layouts/application.html.erb @@ -27,7 +27,7 @@ -
+

Austen Said:

Patterns of Diction in Jane Austen's Major Novels

@@ -56,7 +56,7 @@
-
+
From 80a5938bdf49a043fbdc5fdb492a818557a52e72 Mon Sep 17 00:00:00 2001 From: Nicole Gray Date: Mon, 6 Apr 2026 11:50:08 -0500 Subject: [PATCH 04/19] add skip to main --- app/views/layouts/application.html.erb | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb index 52b7071..ec31fa1 100644 --- a/app/views/layouts/application.html.erb +++ b/app/views/layouts/application.html.erb @@ -26,7 +26,10 @@ - + + Skip to main content + +

Austen Said:

Patterns of Diction in Jane Austen's Major Novels

From 612c8614e45a08a91e29a2352edc6bb46eda0985 Mon Sep 17 00:00:00 2001 From: Nicole Gray Date: Mon, 6 Apr 2026 11:51:38 -0500 Subject: [PATCH 05/19] add aria-label to navbar toggle button --- app/views/layouts/application.html.erb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb index ec31fa1..2819767 100644 --- a/app/views/layouts/application.html.erb +++ b/app/views/layouts/application.html.erb @@ -39,7 +39,7 @@
-
-
+
+
From 779c288af912afdaca129fa851a89dbb93dfb64e Mon Sep 17 00:00:00 2001 From: Nicole Gray Date: Mon, 6 Apr 2026 12:00:01 -0500 Subject: [PATCH 07/19] shift to main and footer landmarks, update links and add alt text for logo image --- app/views/layouts/application.html.erb | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb index 42ea1ef..8f1692e 100644 --- a/app/views/layouts/application.html.erb +++ b/app/views/layouts/application.html.erb @@ -64,19 +64,18 @@
-
+
<%= yield %> -
+ -
-
-
-

Created by the Center for Digital Research in the Humanities.

- -
-
- -
+ From 2699692c1cafc650f704549ae9f43631452dc4b2 Mon Sep 17 00:00:00 2001 From: Nicole Gray Date: Mon, 6 Apr 2026 12:00:42 -0500 Subject: [PATCH 08/19] add header id --- app/views/layouts/application.html.erb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb index 8f1692e..13447fc 100644 --- a/app/views/layouts/application.html.erb +++ b/app/views/layouts/application.html.erb @@ -30,7 +30,7 @@ Skip to main content -
+
@@ -158,7 +161,10 @@
- <%= paginator(@total_pages, 3) %> +

Bottom Pagination

+
From ab4cfcc9a7b61a2e6223303a54c10fbd7651dfc5 Mon Sep 17 00:00:00 2001 From: Nicole Gray Date: Fri, 10 Apr 2026 17:00:59 -0500 Subject: [PATCH 16/19] add page-specific search title, default search page title --- app/controllers/search_controller.rb | 1 + app/views/layouts/application.html.erb | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/app/controllers/search_controller.rb b/app/controllers/search_controller.rb index d416c75..dfe4b6b 100644 --- a/app/controllers/search_controller.rb +++ b/app/controllers/search_controller.rb @@ -14,6 +14,7 @@ def search @docs = $solr.query(options) @total_pages = @docs[:pages] @facets = $solr.get_facets(options) + @title = "Search" end diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb index bb75538..d725909 100644 --- a/app/views/layouts/application.html.erb +++ b/app/views/layouts/application.html.erb @@ -1,7 +1,7 @@ - Austen + <% if @title.present? %><%= @title %> | <% end %>Austen Said From 753f2737df92acde7c3c9e2cd078fa151b379030 Mon Sep 17 00:00:00 2001 From: Nicole Gray Date: Fri, 10 Apr 2026 17:06:37 -0500 Subject: [PATCH 17/19] add search term and facet values to search page title --- app/controllers/search_controller.rb | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/app/controllers/search_controller.rb b/app/controllers/search_controller.rb index dfe4b6b..99f1e91 100644 --- a/app/controllers/search_controller.rb +++ b/app/controllers/search_controller.rb @@ -14,7 +14,16 @@ def search @docs = $solr.query(options) @total_pages = @docs[:pages] @facets = $solr.get_facets(options) - @title = "Search" + # uses the view helper function "any_facets_selected?" + if params["qtext"].present? && view_context.any_facets_selected? + @title = "Search Results: \"#{params["qtext"]}\" - #{display_facets(params)}" + elsif params["qtext"].present? + @title = "Search Results: \"#{params["qtext"]}\"" + elsif view_context.any_facets_selected? + @title = "Search Results: #{display_facets(params)}" + else + @title = "Search the Journals" + end end @@ -45,4 +54,8 @@ def create_search_options(aParams) end return options end + + def display_facets(params) + params.except(:action,:sort,:controller,:qfield,:qtext,:commit,:rows).values.compact_blank.join(" / ") + end end \ No newline at end of file From 2019eebdbe23bbf07d79317875179bfad05cb031 Mon Sep 17 00:00:00 2001 From: Nicole Gray Date: Fri, 10 Apr 2026 17:07:36 -0500 Subject: [PATCH 18/19] adjust default search title --- app/controllers/search_controller.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/controllers/search_controller.rb b/app/controllers/search_controller.rb index 99f1e91..02344d0 100644 --- a/app/controllers/search_controller.rb +++ b/app/controllers/search_controller.rb @@ -22,7 +22,7 @@ def search elsif view_context.any_facets_selected? @title = "Search Results: #{display_facets(params)}" else - @title = "Search the Journals" + @title = "Search" end end From c2874553837a7d70d37f3ecad707ec9c98a16f18 Mon Sep 17 00:00:00 2001 From: Nicole Gray Date: Mon, 13 Apr 2026 11:00:01 -0500 Subject: [PATCH 19/19] refactor search page title facet code --- app/controllers/search_controller.rb | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/app/controllers/search_controller.rb b/app/controllers/search_controller.rb index 02344d0..671948a 100644 --- a/app/controllers/search_controller.rb +++ b/app/controllers/search_controller.rb @@ -14,12 +14,14 @@ def search @docs = $solr.query(options) @total_pages = @docs[:pages] @facets = $solr.get_facets(options) - # uses the view helper function "any_facets_selected?" - if params["qtext"].present? && view_context.any_facets_selected? + # add search terms and filters to page title + title_facets = Facets.facet_list.map(&:to_s) << "page" + param_keys = params.keys + if params["qtext"].present? && param_keys.intersect?(title_facets) @title = "Search Results: \"#{params["qtext"]}\" - #{display_facets(params)}" elsif params["qtext"].present? @title = "Search Results: \"#{params["qtext"]}\"" - elsif view_context.any_facets_selected? + elsif param_keys.intersect?(title_facets) @title = "Search Results: #{display_facets(params)}" else @title = "Search"