Skip to content

🐛 [BUG] - Tx error handler Hook can’t influence classification (due to the void return); docs suggest Result-based handling #384

@IaroslavMazur

Description

@IaroslavMazur

Description

In Trident 0.11.0, TransactionHooks::transaction_error_handler() returns nothing (i.e. void) and is invoked after the Fuzzer has already recorded the transaction as "failed". This prevents the test author from marking certain errors as “expected” and, therefore, reclassifying them.

At the same time, the docs and the fn name, itself, imply that the hook can “handle” errors. In practice, however, the hook only lets you observe the errors - not "handle" them.

Reproduction steps

1. Write a Fuzzing test that results in an expected error (i.e. which is handled by the tested program)
2. Try to "validate" the error/mark it as "expected"
3. Observe that the executed Ix still appears in the "Ix Failed" column in the fuzzing report

OS

Mac

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions